No checkin: overloaded-box protocol changes
#22006
Closed
+652
−187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r>`. Note that `box <expr>` itself remains unchanged.
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
|
(much of the above fallout is made unnecessary by #22012. I hope to have a new PR reflecting the improvement up soon.) |
This was referenced Feb 7, 2015
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Feb 10, 2015
…object-cast Given `<expr> as Box<Trait>`, infer that `Box<_>` is expected type for `<expr>`. This is useful for addressing fallout from newly proposed box protocol; see rust-lang#22006 for examples of such fallout, much of which will be unnecessary with this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bootstrapping illustration of the new box prototype. The main point is to illustrate the fallout that occurs with the compiler type inference as it stands today.
(Notably, we do not infer
Box<_>forbox <expr>in the context of(box <expr> as Box<Trait>), and this weakness is a cause of a lot of the fallout below.)pnkfelix is trying to see if he can revise
vtable::check_object_castto remove the above limitation, which would let us revert a lot of the fallout below.see also rust-lang/rfcs#809 (which is not merged as of this writing).